kvstoremesh: don't disable by default #2660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 1.16 we enabled kvstoremesh by default in helm. Currently, cilium-cli was still setting kvstoremesh.enabled to false. Now, if user does not explicitly specify if kvstoremesh should be enabled or disabled, we will rely on default helm value. Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
squeed
approved these changes
Jul 5, 2024
maintainer-s-little-helper
bot
added
the
ready-to-merge
marseel
added a commit
to marseel/cilium
that referenced
this pull request
Jul 10, 2024
With KVStoreMesh enabled by default, we rely on having cluster id. Currently, external-workloads did not have it set in CI, which was causing CI failure when trying to update cilium-cli containing change from cilium/cilium-cli#2660 Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
This was referenced Jul 10, 2024
github-merge-queue bot
pushed a commit
to cilium/cilium
that referenced
this pull request
Jul 10, 2024
With KVStoreMesh enabled by default, we rely on having cluster id. Currently, external-workloads did not have it set in CI, which was causing CI failure when trying to update cilium-cli containing change from cilium/cilium-cli#2660 Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
giorio94
pushed a commit
to cilium/cilium
that referenced
this pull request
Jul 15, 2024
[ upstream commit 2c7df4f ] With KVStoreMesh enabled by default, we rely on having cluster id. Currently, external-workloads did not have it set in CI, which was causing CI failure when trying to update cilium-cli containing change from cilium/cilium-cli#2660 Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com> Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
giorio94
pushed a commit
to cilium/cilium
that referenced
this pull request
Jul 15, 2024
[ upstream commit 2c7df4f ] With KVStoreMesh enabled by default, we rely on having cluster id. Currently, external-workloads did not have it set in CI, which was causing CI failure when trying to update cilium-cli containing change from cilium/cilium-cli#2660 Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com> Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
aanm
pushed a commit
to cilium/cilium
that referenced
this pull request
Jul 15, 2024
[ upstream commit 2c7df4f ] With KVStoreMesh enabled by default, we rely on having cluster id. Currently, external-workloads did not have it set in CI, which was causing CI failure when trying to update cilium-cli containing change from cilium/cilium-cli#2660 Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com> Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 1.16 we enabled kvstoremesh by default in helm. Currently, cilium-cli was still setting kvstoremesh.enabled to false. Now, if user does not explicitly specify if kvstoremesh should be enabled or disabled, we will rely on default helm value.