Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Bourbon and Neat Dependencies #1

Closed
robneu opened this issue Dec 14, 2015 · 2 comments
Closed

Remove Bourbon and Neat Dependencies #1

robneu opened this issue Dec 14, 2015 · 2 comments

Comments

@robneu
Copy link
Collaborator

robneu commented Dec 14, 2015

We honestly don't use either of these for much at all anymore. Autoprefixer makes a lot of the mixins in Bourbon unnecessary and there are smaller libraries to handle the few things that we do use such as Modular Scale and media queries.

The one thing that would be a little difficult to replace is Neat. The only viable alternative I've found is Flexbox Grid which has a Sass version but it's still in development and hasn't been updated in a while.

We could roll our own grid system, but I'm not very familiar with flexbox and I've run into some performance issues with it on other builds.

@GaryJones
Copy link

I'm in agreement for my own projects too. 80% of Sass features I use are built-in to Sass, and much of this can be handled with PostCSS anyway. I've got one project that uses Neat, but otherwise barely touches Bourbon.

@robneu robneu added this to the 1.0 milestone Dec 19, 2015
robneu added a commit that referenced this issue Dec 23, 2015
robneu added a commit that referenced this issue Dec 23, 2015
robneu added a commit that referenced this issue Dec 23, 2015
robneu added a commit that referenced this issue Dec 23, 2015
robneu added a commit that referenced this issue Dec 24, 2015
Also stopped loading bourbon. Related to #1
@robneu
Copy link
Collaborator Author

robneu commented Dec 24, 2015

This is finished. I think I'll probably leave the actual node-neat package in our theme config to make working with projects which use the library a little easier.

Some plugins, most notably WooCommerce, use Bourbon and Neat within their Sass files, so having it available can be useful sometimes.

@robneu robneu closed this as completed Dec 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants