Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

Allow select out of stock #23

Merged
merged 6 commits into from
Apr 25, 2012
Merged

Conversation

sbounmy
Copy link
Contributor

@sbounmy sbounmy commented Apr 21, 2012

Hello @citrus !

I don't know if this is a personal feature or not but I needed to be able to select out of stock variants to be able to allow customers to add them to their wishlist with spree_wishlist.

I've changed spree_variant_options to support :

SpreeVariantOptions::VariantConfig.allow_select_outofstock = true

What it does ?

  • allow select out of stock variants
  • update form variant_id with html attribute data-form-type = "variant"
  • enable the data-form-type = "variant" 's submit buttons

Some integration tests comes along with this PR.

A demo is worth than a thousand of words : http://hallyustyle.com/en/products/style-up-loose-fit-knit-back-lace

Let me know if you have any questions !

Stephane 🍺 🍺

@citrus
Copy link
Owner

citrus commented Apr 25, 2012

Hey Stephane,

So sorry I haven't merged this yet! Been busy with some non-spree stuff :/

-Spencer

citrus added a commit that referenced this pull request Apr 25, 2012
@citrus citrus merged commit 136f03a into citrus:master Apr 25, 2012
@sbounmy
Copy link
Contributor Author

sbounmy commented Apr 26, 2012

no worries :) hope to see you soon on spree stuffs hehe

@sbounmy sbounmy deleted the allow_select_out_of_stock branch December 6, 2013 09:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants