-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename school beacon component #1434
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested created a new school zone beacon, and I see the updated naming in the app and in all associated database views. Up and down migration worked too! Thanks for tidying the permissions too! 🙌 🚀
@@ -0,0 +1 @@ | |||
UPDATE moped_components SET component_name = 'Beacon', component_subtype = 'School Zone' WHERE component_id = 39 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll have a PR that updates a record in this table too, and I cautiously wrote my migration to avoid using the record id. I think that we would only run into a problem if we updated the ids in the future, right?
fwiw i found this previous discussion about the same thing when I looked through old migration code to see if we've updated by component_id
before. We have!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what would be the alternative to updating by component_id
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
John proposed in that thread that Mike linked above to do something like where component_name like '%refuge%'-
so I guess in this case it would have to be where component_subtype = School Zone Beacon
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 🚢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! i see the new naming in the map and across the app and also applied the down migration (insert okra thumbs up here)
Associated issues
cityofaustin/atd-data-tech#19040
I also addressed cityofaustin/atd-data-tech#19171, remove delete permissions for the feature tables
Testing
URL to test:
Test locally
Steps to test:
Add a new component to the map, search for a Beacon - School Zone
You can see the new name in the sidebar, as well as in the project list view.
Ship list
- [ ] Product manager added to QA test script if applicable