Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename school beacon component #1434

Merged
merged 2 commits into from
Oct 7, 2024
Merged

Conversation

chiaberry
Copy link
Member

@chiaberry chiaberry commented Sep 27, 2024

Associated issues

cityofaustin/atd-data-tech#19040
I also addressed cityofaustin/atd-data-tech#19171, remove delete permissions for the feature tables

Testing

URL to test:

Test locally

Steps to test:

Add a new component to the map, search for a Beacon - School Zone

Screenshot 2024-09-27 at 2 21 21 PM

You can see the new name in the sidebar, as well as in the project list view.


Ship list

Copy link
Collaborator

@mddilley mddilley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested created a new school zone beacon, and I see the updated naming in the app and in all associated database views. Up and down migration worked too! Thanks for tidying the permissions too! 🙌 🚀

@@ -0,0 +1 @@
UPDATE moped_components SET component_name = 'Beacon', component_subtype = 'School Zone' WHERE component_id = 39
Copy link
Collaborator

@mddilley mddilley Sep 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have a PR that updates a record in this table too, and I cautiously wrote my migration to avoid using the record id. I think that we would only run into a problem if we updated the ids in the future, right?

fwiw i found this previous discussion about the same thing when I looked through old migration code to see if we've updated by component_id before. We have!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what would be the alternative to updating by component_id?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

John proposed in that thread that Mike linked above to do something like where component_name like '%refuge%'- so I guess in this case it would have to be where component_subtype = School Zone Beacon?

Copy link
Member

@johnclary johnclary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🚢

Copy link
Contributor

@roseeichelmann roseeichelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! i see the new naming in the map and across the app and also applied the down migration (insert okra thumbs up here)

@chiaberry chiaberry merged commit dd2a968 into main Oct 7, 2024
4 checks passed
@chiaberry chiaberry deleted the 19040-update-school-beacon-name branch October 10, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants