-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Files table to data grid #1438
Merged
Merged
Changes from 25 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
9b5dfb3
the data is rendering
chiaberry 8eec112
add the toolbar and more of the edits
chiaberry 3b32597
linting
chiaberry 33891f7
delete a row
chiaberry 5795234
able to edit a row
chiaberry 4031490
validate input in data grid
chiaberry 4c4effe
remove older props
chiaberry 31a99ba
ability to edit the type select in data grid
chiaberry d27ceb9
looks like we dont need the field selector
chiaberry 06ab1bc
remove the unneeded text field
chiaberry ed304bd
fix external link rendering
chiaberry 924295e
add delete confirmation modal to files table
chiaberry 5831ccb
tabbing seems to work without the handler
chiaberry bf5c6b8
update comment
chiaberry 65f27a2
updating the value getter so the sort workds
chiaberry 610c3c4
Merge branch 'main' into 18176-data-grid-files
chiaberry 44b9852
check if value exists, dont try to trim null
chiaberry 2c9623c
description is not required
chiaberry b2f79e3
fill width more or less of parent component
chiaberry 19fdb86
clean up payload
chiaberry 82c3335
use data grid sort comparator
chiaberry 6348377
write a handler to validate file input
chiaberry 1dc2d3b
break the words
chiaberry c0fbe1e
ignore the audit fields in in the files activity log
chiaberry d42a31a
order files by created at desc
chiaberry fd1ce13
give the file size column a size
chiaberry File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nice to see this component growing up to handle validation! 🌱 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐛 squashed! 🙏