adds components dropdown and contains not operator #1439

tillyw · 2024-10-03T20:35:03Z

Associated issues

fixes cityofaustin/atd-data-tech#19052

Testing

URL to test:

https://deploy-preview-1439--atd-moped-main.netlify.app/

Steps to test:

note the number of records in the project view with no filters applied
add an advanced filter for 'components' 'contains', select an option and note the number of records
replace the filter with the same query but using the 'does not contain' operator, and note whether the number of records makes up the difference. also check to make sure records with no value in the 'component' field appear.
repeat the steps with the 'is' and 'is not' operators for a different field (such as 'type')
confirm that fields with the 'is' and 'contains' operators also include their opposites

Ship list

Code reviewed
Product manager approved
Product manager checked DB view dependencies
Product manager added to QA test script if applicable
- Added to the existing "contains" test to check the sum of "contains" and "does not contain" to make sure it equals the total number of projects

chiaberry

The test instructions say to repeat the steps with "is" and "is not" but I don't see them in the components drop down options

I dont see that requirement in the issue, so I dont know if its okay its not there or if its an oversight

roseeichelmann · 2024-10-09T19:50:21Z

moped-editor/src/views/projects/projectsListView/useProjectListViewQuery/useAdvancedSearch.js

@@ -63,6 +63,11 @@ const makeAdvancedSearchWhereFilters = (filters) =>
        }
      }
      let whereString = `${field}: { ${gqlOperator}: ${value} }`;
+      // If we would like to return results that do not contain a particular string ('_nilike'), we should return null values as well
+      if (gqlOperator.includes("_nilike")) {
+        const whereStringWithNullValues = `_or: [ { ${whereString} }, { ${field}: { ${`_is_null`}: true } }]`;


nice touch 👌

+1 to that! I tested stacking filters to exclude overlapping matches, and this works so well! 🚀

It is great that this change covers both the "is not" and "does not contain" operators too!

roseeichelmann

looks and works great! i noticed what chia pointed out too but im approving on the assumption that you meant to write "is blank" and "is not blank" in the test instructions since adding is and is not isn't in the issue requirements

tillyw · 2024-10-09T21:25:08Z

oops sorry @chiaberry, i meant to check one of the other fields that has 'is' and 'is not' options (such as 'type') since this pr also corrects an issue where records with null values were not being returned under the 'is not' condition. made a correction in the instructions - thanks for catching that!

chiaberry

Thanks for the clarification Tilly! I tested with Lead is not COA ATD and got all the results, whereas in staging you only get 179 results

🚢 🚢

mddilley

Such an improvement! I tested using every type of field search (date, string, string that is a concatenated list, and number) and all operators with and without dropdown options, and I see this working exactly as expected. 🚢 🚀 🙌

mddilley · 2024-10-09T22:51:01Z

moped-editor/src/views/projects/projectsListView/useProjectListViewQuery/useAdvancedSearch.js

@@ -63,6 +63,11 @@ const makeAdvancedSearchWhereFilters = (filters) =>
        }
      }
      let whereString = `${field}: { ${gqlOperator}: ${value} }`;
+      // If we would like to return results that do not contain a particular string ('_nilike'), we should return null values as well
+      if (gqlOperator.includes("_nilike")) {
+        const whereStringWithNullValues = `_or: [ { ${whereString} }, { ${field}: { ${`_is_null`}: true } }]`;


+1 to that! I tested stacking filters to exclude overlapping matches, and this works so well! 🚀

It is great that this change covers both the "is not" and "does not contain" operators too!

tillyw · 2024-10-10T00:07:17Z

thanks y'all! gonna go ahead and merge this one :)

adds components dropdown and contains not operator

b551f34

tillyw added the WIP Work in progress label Oct 3, 2024

tillyw added 4 commits October 3, 2024 16:10

added missing operators

3ca4293

returns null values

b9c70f1

fix 'is not' operator'

d3ea800

minor modifications

9edf1c5

tillyw removed the WIP Work in progress label Oct 8, 2024

tillyw requested review from chiaberry, mddilley, johnclary, roseeichelmann and frankhereford October 9, 2024 16:09

chiaberry reviewed Oct 9, 2024

View reviewed changes

roseeichelmann reviewed Oct 9, 2024

View reviewed changes

roseeichelmann approved these changes Oct 9, 2024

View reviewed changes

chiaberry approved these changes Oct 9, 2024

View reviewed changes

mddilley approved these changes Oct 9, 2024

View reviewed changes

tillyw merged commit 7021c0b into main Oct 10, 2024
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

adds components dropdown and contains not operator #1439

adds components dropdown and contains not operator #1439

tillyw commented Oct 3, 2024 •

edited by mddilley

Loading

chiaberry left a comment

roseeichelmann Oct 9, 2024

mddilley Oct 9, 2024

roseeichelmann left a comment

tillyw commented Oct 9, 2024 •

edited

Loading

chiaberry left a comment

mddilley left a comment

mddilley Oct 9, 2024

tillyw commented Oct 10, 2024

adds components dropdown and contains not operator #1439

adds components dropdown and contains not operator #1439

Conversation

tillyw commented Oct 3, 2024 • edited by mddilley Loading

Associated issues

Testing

Ship list

chiaberry left a comment

Choose a reason for hiding this comment

roseeichelmann Oct 9, 2024

Choose a reason for hiding this comment

mddilley Oct 9, 2024

Choose a reason for hiding this comment

roseeichelmann left a comment

Choose a reason for hiding this comment

tillyw commented Oct 9, 2024 • edited Loading

chiaberry left a comment

Choose a reason for hiding this comment

mddilley left a comment

Choose a reason for hiding this comment

mddilley Oct 9, 2024

Choose a reason for hiding this comment

tillyw commented Oct 10, 2024

tillyw commented Oct 3, 2024 •

edited by mddilley

Loading

tillyw commented Oct 9, 2024 •

edited

Loading