Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moar <FormattedDateString> #1450

Merged
merged 4 commits into from
Oct 10, 2024
Merged

Conversation

mateoclarke
Copy link
Contributor

@mateoclarke mateoclarke commented Oct 9, 2024

Associated issues

Closes cityofaustin/atd-data-tech#19044

Testing

URL to test:

Since this is a PR off a branch from main (chia's PR), we'll have to test this locally until that upstream PR branch is merged to main

Steps to test:

  1. Check the Modified column and the date format for each row on the project list
  1. Check the Date uploaded column in the project files tab table for the expected date formatting
  1. Check the 3rd column in the Project Activity log for the expected date formatting

Ship list

Copy link
Collaborator

@mddilley mddilley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I requested two tiny changes - this looks amazing! Thank you for spreading this component to more places! 🎉

@chiaberry chiaberry changed the base branch from 18176-data-grid-files to main October 10, 2024 13:58
@chiaberry
Copy link
Member

I merged the upstream branch and switched the base branch to main, hoping it would trigger a netlify deploy but alas no

Copy link
Collaborator

@mddilley mddilley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love seeing this component in more places - thanks! ⏳ 🙌 🚢

Copy link
Member

@chiaberry chiaberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its 🕦 to 🚢

@mateoclarke mateoclarke merged commit 4b00bce into main Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update other timestamp displays with FormattedDateString component
3 participants