Updated images to be compatible with Apple chip. #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexSkrypnyk
added
State: DO NOT MERGE
AlexSkrypnyk
added
State: Needs review
AlexSkrypnyk
commented
Nov 22, 2021
| @@ -190,7 +190,7 @@ fi | |||
| # "drupal-install-site-" prefix and ".sh" extension. | |||
| if [ -d "${APP}/scripts/custom" ]; then | |||
| for file in "${APP}"/scripts/custom/drupal-install-site-*.sh; do | |||
| if [ -r "${file}" ]; then | |||
| if [ -f "${file}" ]; then | |||
There was a problem hiding this comment.
upstream bug in Alpine (alpinelinux/docker-alpine#156) - but we do not need -r - -f is enough to check if file exists.
This change is added to DrevOps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AIO has already published images with multi-architecture support, but they published them in
uselagoonDockerHub namespace (they usually double-publish them inamazeeioanduselagoonnamespaces;amazeeiois deprecated now).Changed
uselagoonnamespace and update to the latest version.How to test
ahoy buildhttps://nginx-php.pr-230.civic.au2.amazee.io/