Use request cr changes

[sebelga]

This PR adds the refactor of the useRequest() hook to not use references but callBacks to define the handlers.
Happy to walk over the code with you tomorrow if you have any questions on why this is a better approach on defining handlers and dependencies.

I also fixed the bug where providing new object query or body triggered infinite request sent.

[sebelga]

I copied over your logic here in a "default" onChange handler to not make a bigger refactor.

[sebelga]

From what we discussed yesterday, I've been thinking and it's the first useEffect that we could remove.

So the end result is

// Send the request on component mount
// + anytime the deps of sendRequest() change
useEffect(() => {
  sendRequest();
}, [sendRequest]);

// Schedule a new request each time a request fulfills ("totalRequests" increment)
// + anytime the deps of scheduleRequest() change
useEffect(() => {
  if (isMounted.current === false) {
    // Don't schedule on component mount
    return;
  }

  scheduleRequest();

  return cleanUpPollInterval;
}, [totalRequests, scheduleRequest, cleanUpPollInterval]);

useEffect(() => {
  isMounted.current = true;

  return () => {
    isMounted.current = false;
  };
}, []);

[sebelga]

And this revealed a bug in the test for pollInterval. We need to wait for twice the amount of time to check for the sendRequestSpy to have been called. We wait once for the pollIntervalMs to pass and once for the setTimeout time to pass (defined in the mock HTTP client post() handler). @cjcenizal

So the test becomes

describe('pollIntervalMs', () => {
  it('sends another request after the specified time has elapsed', async () => {
    const { setupSuccessRequest, advanceTime, getSendRequestSpy } = helpers;
    setupSuccessRequest({ pollIntervalMs: REQUEST_TIME });

    await advanceTime(REQUEST_TIME);
    expect(getSendRequestSpy().callCount).toBe(1);

    // We need to advance (1) the pollIntervalMs and (2) the request time
    await advanceTime(REQUEST_TIME * 2);
    expect(getSendRequestSpy().callCount).toBe(2);

    await advanceTime(REQUEST_TIME * 2);
    expect(getSendRequestSpy().callCount).toBe(3);
  });
});