Fixes jQueryUI #8914: Avoid cssHook blending in non-rgba browsers whe…

…n the value is "transparent"
cjiewong · Jan 3, 2013 · aeeff3d · aeeff3d
1 parent b05afc5
commit aeeff3d
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/jquery.color.js b/jquery.color.js
@@ -578,7 +578,7 @@ color.hook = function( hook ) {
 				var parsed, curElem,
 					backgroundColor = "";
 
-				if ( jQuery.type( value ) !== "string" || ( parsed = stringParse( value ) ) ) {
+				if ( value !== "transparent"  && ( jQuery.type( value ) !== "string" || ( parsed = stringParse( value ) ) ) ) {
 					value = color( parsed || value );
 					if ( !support.rgba && value._rgba[ 3 ] !== 1 ) {
 						curElem = hook === "backgroundColor" ? elem.parentNode : elem;

diff --git a/test/unit/color.js b/test/unit/color.js
@@ -624,6 +624,16 @@ test( "Setting CSS to empty string / inherit", function() {
 	ok( el[0].style.color === "" || el[0].style.color === "inherit", "Setting CSS to inherit didn't throw error" );
 });
 
+test( "Setting CSS to transparent", function() {
+	expect( 1 );
+
+	var parentEl = jQuery("<div></div>").appendTo("body").css({ backgroundColor: "blue" }),
+		el = jQuery("<div></div>").appendTo( parentEl );
+
+	el.css( "backgroundColor", "transparent" );
+	equal( jQuery.Color( el[ 0 ].style.backgroundColor ).alpha(), 0, "CSS was set to transparent" );
+});
+
 test( "jQuery.Color.hook() - Create new hooks for color properties", 2, function() {
 
 	// these shouldn't be there, but just in case....