Use "." in install() instead of DistributionFormat #183
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the same type signature for
install
thatnox.Session.install
uses.The function no longer accepts
DistributionFormat
values in its arguments list. Useinstallroot
instead.Rationale
Besides the advantages of symmetry, this will allow us to handle extras for the local package. The enum-based interface does not allow expressing extras. By moving the translation logic from the patched
Session.install
function toinstall
, we are able to pass arguments like".[extra]"
. Interpreting extras as appropriate is left for a follow-up.