Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "." in install() instead of DistributionFormat #183

Merged
merged 5 commits into from
Dec 2, 2020
Merged

Conversation

cjolowicz
Copy link
Owner

@cjolowicz cjolowicz commented Nov 30, 2020

Use the same type signature for install that nox.Session.install uses.

The function no longer accepts DistributionFormat values in its arguments list. Use installroot instead.

Rationale

Besides the advantages of symmetry, this will allow us to handle extras for the local package. The enum-based interface does not allow expressing extras. By moving the translation logic from the patched Session.install function to install, we are able to pass arguments like ".[extra]". Interpreting extras as appropriate is left for a follow-up.

@cjolowicz cjolowicz merged commit ec10b1f into master Dec 2, 2020
@cjolowicz cjolowicz deleted the install-dot branch December 2, 2020 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking Changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant