feat: use pip sources config from poetry #679
Conversation
src/nox_poetry/sessions.py
Outdated
| """Convert the pip sources in to index url args.""" | ||
| # TODO: add http basic-auth to the urls generated from the poetry config? | ||
| index_args = () |
There was a problem hiding this comment.
I would also like your thoughts on this.
There was a problem hiding this comment.
From the docs here and playing with it I think poetry uses both the user keychain and a fallback file to store those creds.. that could be a big lift to implement.
|
I'm also not sure how to handle sources marked as |
|
Thank you for working on this! I would prefer an approach where we forward pip options from the requirements file generated by Poetry. This has the advantage that we don't duplicate functionality already present in What do you think? |
|
I love the concept. I will have to check and see if the info is in there.. i thought it was not. Do you know of a valid format for including it in a requirements file? I was looking for that info before starting this and did not find anything, but i did not spend too long looking. I will search again |
|
Oh wow, it looks like you can just include |
|
and as of poetry version 1.1.13 that index url is already included in the export file. Fantastic |
|
Sorry, I had incorrectly set up my changes on EDIT: continued in #887 |
Thank you for this awesome plugin! I intend this to add the feature you had discussed in #398.
Closes #398
I have a very basic implementation of this set up here. The test suite is still running so I haven't installed and tested with my own projects yet.
I would like your feedback on implementation before I update tests and documentation, and if you could let me know how extensively you would like this tested that would be great :)