Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to plain HTTP library to avoid quirks in jsonrpc-client #6

Closed
xxuejie opened this issue Jun 2, 2020 · 1 comment
Closed

Move to plain HTTP library to avoid quirks in jsonrpc-client #6

xxuejie opened this issue Jun 2, 2020 · 1 comment
Labels

Comments

@xxuejie
Copy link
Collaborator

xxuejie commented Jun 2, 2020

Right now lumos indexer uses JSONRPC client library as used in ckb-indexer. But one problem with this library, is that it is hardcoded with hyper::rt, which makes it impossible to swap runtime. To make matters worse, hyper::rt uses a tokio in a mode that forbids running on a single core machine.

Since we only need JSONRPC for one API, it won't be a problem for us to build the specific code we need on a plain HTTP library, which would has better async/await support, such as surf.

@xxuejie xxuejie added the indexer label Jun 2, 2020
homura pushed a commit that referenced this issue Feb 18, 2022
* chore: start ckb-indexer test env

* chore: install ts-node in CI

* chore: install dependencies

* chore: fix start test env error

* test: test ckb-indexer

* test(ckb-indexer): fix wrong file path

* test(ckb-indexer): increase waitting time

* chore: add github publish workflow

* chore: delete ckb2021 branch and publish issues comment
@homura
Copy link
Collaborator

homura commented Jun 8, 2023

Lumos doesn't the support native indexer anymore, so we can close this issue

@homura homura closed this as completed Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants