Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: recommended eslint rules for TS #295

Merged
merged 3 commits into from
Mar 14, 2022
Merged

Conversation

homura
Copy link
Collaborator

@homura homura commented Mar 11, 2022

This PR adds stricter eslint rules, and these new rules will only affect files that have been changed (ACMR)

Here is an example https://github.com/homura/lumos/runs/5505186540?check_suite_focus=true

@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #295 (46a0bdf) into develop (f4314c3) will increase coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #295      +/-   ##
===========================================
+ Coverage    76.15%   76.30%   +0.15%     
===========================================
  Files           57       57              
  Lines        18442    18515      +73     
  Branches      1542     1563      +21     
===========================================
+ Hits         14044    14128      +84     
+ Misses        4382     4369      -13     
- Partials        16       18       +2     
Impacted Files Coverage Δ
packages/common-scripts/src/index.ts 100.00% <0.00%> (ø)
packages/helpers/src/index.ts 81.16% <0.00%> (+6.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4314c3...46a0bdf. Read the comment docs.

@homura homura merged commit 228f8f6 into ckb-js:develop Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant