Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rebuild lumos API docs when building website #371

Merged
merged 2 commits into from
Jul 21, 2022

Conversation

homura
Copy link
Collaborator

@homura homura commented Jul 21, 2022

the last PR #369 I forgot to build Lumos API when deploying the website, this PR has fixed it

@vercel
Copy link

vercel bot commented Jul 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
lumos-website ✅ Ready (Inspect) Visit Preview Jul 21, 2022 at 5:57AM (UTC)

@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #371 (52fefd3) into develop (3380546) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #371   +/-   ##
========================================
  Coverage    82.24%   82.24%           
========================================
  Files           81       81           
  Lines        17659    17659           
  Branches      1695     1695           
========================================
  Hits         14524    14524           
  Misses        3112     3112           
  Partials        23       23           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3380546...52fefd3. Read the comment docs.

Copy link
Contributor

@zhangyouxin zhangyouxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@homura homura merged commit d91a96f into ckb-js:develop Jul 21, 2022
@homura homura deleted the fix-api-doc branch July 21, 2022 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants