Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add pr template #394

Merged
merged 3 commits into from
Sep 7, 2022
Merged

Conversation

zhangyouxin
Copy link
Contributor

@zhangyouxin zhangyouxin commented Aug 31, 2022

Description

This PR aims to provide a template for PRs, thus contributors can fill out the skeleton when creating a PR.

Type of change

  • docs (non-breaking change)

How Has This Been Tested?

Just try creating a PR and this template will show up for you to fill in.

An example: zhangyouxin#18

@vercel
Copy link

vercel bot commented Aug 31, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
lumos-website ✅ Ready (Inspect) Visit Preview Sep 4, 2022 at 11:41PM (UTC)

@zhangyouxin zhangyouxin changed the title chore(lumos): add pr template chore: add pr template Aug 31, 2022
@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #394 (6d2ca91) into develop (f244d81) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #394      +/-   ##
===========================================
+ Coverage    81.94%   81.98%   +0.04%     
===========================================
  Files           93       93              
  Lines        19003    19105     +102     
  Branches      1785     1794       +9     
===========================================
+ Hits         15572    15664      +92     
- Misses        3390     3400      +10     
  Partials        41       41              
Impacted Files Coverage Δ
packages/ckb-indexer/src/services.ts 47.47% <0.00%> (-1.49%) ⬇️
packages/ckb-indexer/src/type.ts 100.00% <0.00%> (ø)
packages/ckb-indexer/src/index.ts 100.00% <0.00%> (ø)
packages/ckb-indexer/src/paramsFormatter.ts 92.30% <0.00%> (ø)
packages/ckb-indexer/src/resultFormatter.ts 95.83% <0.00%> (+0.08%) ⬆️
packages/helpers/src/index.ts 86.63% <0.00%> (+0.91%) ⬆️
packages/ckb-indexer/src/collector.ts 52.10% <0.00%> (+1.18%) ⬆️
packages/ckb-indexer/src/rpc.ts 37.93% <0.00%> (+1.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f244d81...6d2ca91. Read the comment docs.

.github/PULL_REQUEST_TEMPLATE Show resolved Hide resolved
.github/PULL_REQUEST_TEMPLATE Outdated Show resolved Hide resolved
@homura homura merged commit 2049ff9 into ckb-js:develop Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants