Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common-scripts): avoid run vm1 code in vm0 when deploy #400

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

homura
Copy link
Collaborator

@homura homura commented Sep 2, 2022

ckb-vm has upgraded and the vm1 is compatible with vm0, but vm0 is not full supported vm1, we should avoid running vm1's code in vm0

@vercel
Copy link

vercel bot commented Sep 2, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
lumos-website ✅ Ready (Inspect) Visit Preview Sep 2, 2022 at 5:11AM (UTC)

@codecov
Copy link

codecov bot commented Sep 2, 2022

Codecov Report

Merging #400 (9790e1f) into develop (d5e7636) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #400   +/-   ##
========================================
  Coverage    81.93%   81.93%           
========================================
  Files           93       93           
  Lines        18997    18997           
  Branches      1788     1788           
========================================
  Hits         15566    15566           
  Misses        3390     3390           
  Partials        41       41           
Impacted Files Coverage Δ
packages/common-scripts/src/deploy.ts 88.48% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5e7636...9790e1f. Read the comment docs.

@homura homura changed the title fix(common-scripts): avoid run vm1 code in vm0 fix(common-scripts): avoid run vm1 code in vm0 when deploy Sep 2, 2022
Copy link
Contributor

@zhangyouxin zhangyouxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@homura homura merged commit e33aaa1 into ckb-js:develop Sep 13, 2022
@homura homura deleted the deprecated-vm0 branch September 13, 2022 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants