-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(website): add tutorial document #412
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## develop #412 +/- ##
===========================================
+ Coverage 81.98% 82.28% +0.29%
===========================================
Files 93 95 +2
Lines 19105 19701 +596
Branches 1794 1863 +69
===========================================
+ Hits 15664 16210 +546
- Misses 3400 3437 +37
- Partials 41 54 +13
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think "tell developer where the code in document should be placed" is very important. Should we explictly tell developer that "write these code to which file"
``` shell | ||
npm init | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
User may want to know what this parameter does if some parameters are added , but this is not really our business
The npm init
is a nice experience for the user to create a project through some questions, we don't need to introduce this part of the complexity, if the user knows what they are doing then just go for it
``` | ||
|
||
``` shell | ||
yarn init |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yarn init | |
yarn init -y |
} | ||
``` | ||
|
||
Congratulations! we write a function to get the balance of account, now we can call it to get our balances |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it missing a step to run
npx ts-node wallet.ts
?
::: | ||
|
||
``` ts | ||
console.log(`address: ${address}`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unclear. As a noob, I want to ask, where should I put these two line code? Maybe I think I need to write it at the end of previous wallet.ts
file
Co-authored-by: Yonghui Lin <homura.dev@gmail.com>
Description
Type of change
How Has This Been Tested?
Checklist: