-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(helpers): add validateP2PKHMessage
function
#427
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## develop #427 +/- ##
===========================================
+ Coverage 82.28% 82.39% +0.11%
===========================================
Files 95 97 +2
Lines 19701 19831 +130
Branches 1863 1867 +4
===========================================
+ Hits 16210 16340 +130
+ Misses 3437 3436 -1
- Partials 54 55 +1
Continue to review full report at Codecov.
|
52f4457
to
ff1d645
Compare
ff1d645
to
43546e0
Compare
validateP2PKHMessage
function
This PR is a fix for #397, can you please describe clearly the purpose of this PR? |
validateP2PKHMessage
functionvalidateP2PKHMessage
function
71cfb41
to
5f5368c
Compare
5f5368c
to
099b020
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the first parameter is optional, then if a parameter is added later it will become breakchange
packages/base/src/utils.d.ts
Outdated
/** | ||
* @param outLength the length of the output hash in bytes. default is `32` | ||
*/ | ||
constructor(outLength?: number); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interface CKBHasherOptions {
outLength?: number;
}
constructor(options?: CKBHasherOptions);
099b020
to
e88d30b
Compare
e88d30b
to
b22e8c2
Compare
b22e8c2
to
e678823
Compare
f69a8d0
to
85d6228
Compare
85d6228
to
989af7c
Compare
989af7c
to
05f0b41
Compare
05f0b41
to
531b2e4
Compare
531b2e4
to
a3a71ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
validateP2PKHMessage
functionvalidateP2PKHMessage
function
Description
Fixes #397
provide a
validateP2PKHMessage
method to check diget == hash(tx | witness), this helps the user to verify that a transaction is tampered.Usage
Type of change
Please delete options that are not relevant.
How Has This Been Tested?