Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: non-existent job in workflow #542

Merged
merged 1 commit into from
Jul 24, 2023
Merged

chore: non-existent job in workflow #542

merged 1 commit into from
Jul 24, 2023

Conversation

homura
Copy link
Collaborator

@homura homura commented Jul 24, 2023

I forgot to remove the unnecessary test job from the workflow.

The release job will open a pull request titled "Version Packages" by the changesets/develop branch, it always up to date with develop, and the pull request workflows have contained all tests, therefor, the needs: test is redundant

@vercel
Copy link

vercel bot commented Jul 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
lumos-website ✅ Ready (Inspect) Visit Preview Jul 24, 2023 1:56am

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #542 (5b5f5cd) into develop (a49c050) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #542   +/-   ##
========================================
  Coverage    86.35%   86.35%           
========================================
  Files          114      114           
  Lines        22917    22917           
  Branches      2310     2310           
========================================
  Hits         19790    19790           
  Misses        3084     3084           
  Partials        43       43           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a49c050...5b5f5cd. Read the comment docs.

@homura homura merged commit 6bb442c into develop Jul 24, 2023
8 checks passed
@homura homura deleted the rm-changeset-needs branch July 24, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants