Robustify markdown link formatter

cknowles · Sep 22, 2015 · 0b036cf · 0b036cf
1 parent dc20b91
commit 0b036cf
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/lib/slack-notifier/link_formatter.rb b/lib/slack-notifier/link_formatter.rb
@@ -52,7 +52,7 @@ def html_pattern
         end
 
         def markdown_pattern
-          /\[(.*?)\]\((.+?)\)/
+          /\[([^\[\]]*?)\]\((https?:\/\/.*?)\)/
         end
 
     end

diff --git a/spec/lib/slack-notifier/link_formatter_spec.rb b/spec/lib/slack-notifier/link_formatter_spec.rb
@@ -15,6 +15,11 @@
       expect( formatted ).to include("<http://example.com|this>")
     end
 
+    it "formats markdown links in brackets" do
+      formatted = described_class.format("Hello World, enjoy [[this](http://example.com) in brackets].")
+      expect( formatted ).to eq("Hello World, enjoy [<http://example.com|this> in brackets].")
+    end
+
     it "formats markdown links with no title" do
       formatted = described_class.format("Hello World, enjoy [](http://example.com).")
       expect( formatted ).to include("<http://example.com>")