Skip to content

Commit

Permalink
net: atm: pppoatm: use new API for wakeup tasklet
Browse files Browse the repository at this point in the history
This converts the driver to use the new tasklet API introduced in
commit 12cc923 ("tasklet: Introduce new initialization API")

Signed-off-by: Emil Renner Berthing <kernel@esmil.dk>
Link: https://lore.kernel.org/r/20210127173256.13954-2-kernel@esmil.dk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
  • Loading branch information
esmil authored and kuba-moo committed Jan 30, 2021
1 parent a5b8863 commit a587459
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions net/atm/pppoatm.c
Original file line number Diff line number Diff line change
Expand Up @@ -101,9 +101,11 @@ static inline struct pppoatm_vcc *chan_to_pvcc(const struct ppp_channel *chan)
* doesn't want to be called in interrupt context, so we do it from
* a tasklet
*/
static void pppoatm_wakeup_sender(unsigned long arg)
static void pppoatm_wakeup_sender(struct tasklet_struct *t)
{
ppp_output_wakeup((struct ppp_channel *) arg);
struct pppoatm_vcc *pvcc = from_tasklet(pvcc, t, wakeup_tasklet);

ppp_output_wakeup(&pvcc->chan);
}

static void pppoatm_release_cb(struct atm_vcc *atmvcc)
Expand Down Expand Up @@ -411,8 +413,7 @@ static int pppoatm_assign_vcc(struct atm_vcc *atmvcc, void __user *arg)
pvcc->chan.ops = &pppoatm_ops;
pvcc->chan.mtu = atmvcc->qos.txtp.max_sdu - PPP_HDRLEN -
(be.encaps == e_vc ? 0 : LLC_LEN);
tasklet_init(&pvcc->wakeup_tasklet, pppoatm_wakeup_sender,
(unsigned long)&pvcc->chan);
tasklet_setup(&pvcc->wakeup_tasklet, pppoatm_wakeup_sender);
err = ppp_register_channel(&pvcc->chan);
if (err != 0) {
kfree(pvcc);
Expand Down

0 comments on commit a587459

Please sign in to comment.