feat(complete)!: Open to new shells for dynamic completions

clap_complete/examples/dynamic.rs

@@ -16,14 +16,14 @@ fn command() -> clap::Command {
                 .value_parser(["json", "yaml", "toml"]),
         )
         .args_conflicts_with_subcommands(true);
-    clap_complete::dynamic::bash::CompleteCommand::augment_subcommands(cmd)
+    clap_complete::dynamic::shells::CompleteCommand::augment_subcommands(cmd)
 }
 
 fn main() {
     let cmd = command();
     let matches = cmd.get_matches();
     if let Ok(completions) =
-        clap_complete::dynamic::bash::CompleteCommand::from_arg_matches(&matches)
+        clap_complete::dynamic::shells::CompleteCommand::from_arg_matches(&matches)
     {
         completions.complete(&mut command());
     } else {

clap_complete/src/dynamic/completer.rs

@@ -3,6 +3,28 @@ use std::ffi::OsString;
 
 use clap_lex::OsStrExt as _;
 
+/// Shell-specific completions
+pub trait Completer {
+    /// The recommended file name for the registration code
+    fn file_name(&self, name: &str) -> String;
+    /// Register for completions
+    fn write_registration(
+        &self,
+        name: &str,
+        bin: &str,
+        completer: &str,
+        buf: &mut dyn std::io::Write,
+    ) -> Result<(), std::io::Error>;
+    /// Complete the command
+    fn write_complete(
+        &self,
+        cmd: &mut clap::Command,
+        args: Vec<std::ffi::OsString>,
+        current_dir: Option<&std::path::Path>,
+        buf: &mut dyn std::io::Write,
+    ) -> Result<(), std::io::Error>;
+}
+
 /// Complete the command specified
 pub fn complete(
     cmd: &mut clap::Command,
@@ -58,7 +80,7 @@ pub fn complete(
 
     Err(std::io::Error::new(
         std::io::ErrorKind::Other,
-        "No completion generated",
+        "no completion generated",
     ))
 }
 

clap_complete/src/dynamic/mod.rs

@@ -2,7 +2,6 @@
 
 mod completer;
 
-pub mod bash;
 pub mod shells;
 
 pub use completer::*;