HOTFIX: Fixed a registration error with the TreeView containers #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parithon
changed the title
clarkio
approved these changes
Sep 25, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
It was brought to my attention that the treeview containers were not working as expected by @clarkio. This is a hotfix to fix the issues.
Cause
When we registered the treeview components with VSCode we reused the same identifier for each panel the treeview is currently in (explorer, debug, and the highlighter panel). I learned that you must have a unique ID for each panel. I made the changes necessary in the
package.jsonandextension.tsfiles to register our treeview with each of the panels separately which solves the problem.