Migrate testing from vscode to @vscode/test-electron #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this contribution @Technickel-Dev. Also great timing as I've decided to bring some focus back onto this project recently 🙂👍 |
|
This looks to be working overall but for some reason I'm seeing the tests run twice. Have you seen this on your end at all? I notice in your screenshot that they're only run once resulting in 5 tests passing but it shows as 10 for me. |
|
Never mind me as I figured it out. I had to clean up my |
clarkio
approved these changes
Oct 15, 2022
|
Glad to help and happy you got it running! If you'll have it, I would love to make some more maintenance-esque PRs. Let me know if there's anything that would be top of your list, otherwise I'll just work on what I see fit. Also just gotta say, checked out your latest Twitch stream after the fact last night and your intro absolutely made my night. Keep on doing your thing! |
|
@Technickel-Dev that's awesome to hear and thanks for sharing. Glad the stream had a positive impact on you! And yes definitely open to more contributions but I've just realized I lost access to publish this extension to the VS Code marketplace. I'm in a holding pattern to see if someone from msft can help recover ownership from my deleted employee account. Don't let that stop you from making contributions where you see opportunities though 🙂👍 |
|
Ok so looks like it's gonna be a bit before I can get the test & build workflow related checks working again. With that in mind I'm going to go ahead and merge this as I tested it all locally and it works fine. Thanks again for this contribution @Technickel-Dev. Also thanks for stopping by the stream again! |
|
@Technickel-Dev did you get credit for this one for Hacktoberfest yet? Let me know if there are any issues with that and if there's something missing from my end to enable you to receive credit. |
|
No worries on timing you do your thing and glad I could stop by! As for credit, it actually just passed the 7 day hold today, so all is good there and nothing needed on your end! Puts me at 3/4 done or on hold :D |
|
@all-contributors please add @Technickel-Dev for code |
|
I've put up a pull request to add @Technickel-Dev! 🎉 |
|
@all-contributors please add @Technickel-Dev for test |
|
I've put up a pull request to add @Technickel-Dev! 🎉 |
clarkio
added a commit
that referenced
this pull request
Apr 21, 2023
* Master (#111) * 0.2.2 Release (#103) * HOTFIX: Fixed a registration error with the TreeView containers * bump version and log changes * add launch for runnin with extensions * Major Upgrade (#123) * Redesigned the entire extension (#112) * Refactored enum types into an enums folder. * Generating 'types' so we can provide types for our API we'll be exposing. * API interface has been added * Started initial refactor to App and expose API * App class is now working. * Twitch chat client is now working * Old credentials removed by default * Added an API entry to verify if a user is following the channel * Fixed an error with the twitch login on linux * Twitch Authentication server callback port is now a setting * Fixed inconsistency in command titles * Fixed bearer token issue * Removed 'token' requirement for followers check, not required * Reverted server port back to static 5544. Must match registered app with Twitch * Updated changelog for 0.5.0 * Context menu support (#115) * Remove highlights by context-menu * Updated changelog * Updated node_modules to fix security vulnerabilities (#113) * Remove Types folder (#116) * Ignore types * Removed types folder * Cleanup and fixed some issues (#122) * Fixed a high vulnerability in node * Fixed authentication issues and updated packages * Fixed promise issues in the highlight * Removed declaration generation * Updated webpack plugins and options * Redesigned the entire extension (#112) * Refactored enum types into an enums folder. * Generating 'types' so we can provide types for our API we'll be exposing. * API interface has been added * Started initial refactor to App and expose API * App class is now working. * Twitch chat client is now working * Old credentials removed by default * Added an API entry to verify if a user is following the channel * Fixed an error with the twitch login on linux * Twitch Authentication server callback port is now a setting * Fixed inconsistency in command titles * Fixed bearer token issue * Removed 'token' requirement for followers check, not required * Reverted server port back to static 5544. Must match registered app with Twitch * Updated changelog for 0.5.0 * Context menu support (#115) * Remove highlights by context-menu * Updated changelog * Updated node_modules to fix security vulnerabilities (#113) * Remove Types folder (#116) * Ignore types * Removed types folder * Cleanup and fixed some issues (#122) * Fixed a high vulnerability in node * Fixed authentication issues and updated packages * Fixed promise issues in the highlight * Removed declaration generation * Updated webpack plugins and options * clarify status bar item actions * No longer alert about saving token, log it! * Updated copyfiles to 2.3.0 to hopefully solve linux issue * Fixed some casing issues for references on linux * fix: change casing of 'twitch' Co-authored-by: clarkio <clarkio@users.noreply.github.com> * Bump elliptic from 6.4.1 to 6.5.3 (#124) Bumps [elliptic](https://github.com/indutny/elliptic) from 6.4.1 to 6.5.3. - [Release notes](https://github.com/indutny/elliptic/releases) - [Commits](indutny/elliptic@v6.4.1...v6.5.3) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * 💯 1.0.0 Release🎉🎊✨🎆 * Update README.md * hotfix(correct reading of settings by name) * remove tmi token from readme requirements * update version for patch * fix(only reconnect on config change if previously connected) * sec: fix deps from audit * 1.0.2 Release * fix: adjust whitespace * AddWebTrends-2020-11 (#131) * Added Web Trends * Added Web Trends * Added Web Trends * Added Web Trends * Added Web Trends * Added Web Trends * Create codeql-analysis.yml * fix: move app to use new twitch app client id (#141) * docs: add parithon as a contributor for code (#145) * docs: update README.md [skip ci] * docs: create .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> * docs: add MatthewKosloski as a contributor for code (#146) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> * docs: add yoannfleurydev as a contributor for code (#147) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> * fix build badge * Bump elliptic from 6.5.3 to 6.5.4 (#133) Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.3 to 6.5.4. - [Release notes](https://github.com/indutny/elliptic/releases) - [Commits](indutny/elliptic@v6.5.3...v6.5.4) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Brian Clark <clarkio@users.noreply.github.com> * Bump ssri from 6.0.1 to 6.0.2 (#136) Bumps [ssri](https://github.com/npm/ssri) from 6.0.1 to 6.0.2. - [Release notes](https://github.com/npm/ssri/releases) - [Changelog](https://github.com/npm/ssri/blob/v6.0.2/CHANGELOG.md) - [Commits](npm/ssri@v6.0.1...v6.0.2) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Brian Clark <clarkio@users.noreply.github.com> * Bump path-parse from 1.0.6 to 1.0.7 (#139) Bumps [path-parse](https://github.com/jbgutierrez/path-parse) from 1.0.6 to 1.0.7. - [Release notes](https://github.com/jbgutierrez/path-parse/releases) - [Commits](https://github.com/jbgutierrez/path-parse/commits/v1.0.7) --- updated-dependencies: - dependency-name: path-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Brian Clark <clarkio@users.noreply.github.com> * Bump tar from 6.0.5 to 6.1.11 (#140) Bumps [tar](https://github.com/npm/node-tar) from 6.0.5 to 6.1.11. - [Release notes](https://github.com/npm/node-tar/releases) - [Changelog](https://github.com/npm/node-tar/blob/main/CHANGELOG.md) - [Commits](isaacs/node-tar@v6.0.5...v6.1.11) --- updated-dependencies: - dependency-name: tar dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Brian Clark <clarkio@users.noreply.github.com> * Bump ini from 1.3.5 to 1.3.8 (#142) Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.8. - [Release notes](https://github.com/isaacs/ini/releases) - [Commits](npm/ini@v1.3.5...v1.3.8) --- updated-dependencies: - dependency-name: ini dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Brian Clark <clarkio@users.noreply.github.com> * Bump y18n from 4.0.0 to 4.0.3 (#143) Bumps [y18n](https://github.com/yargs/y18n) from 4.0.0 to 4.0.3. - [Release notes](https://github.com/yargs/y18n/releases) - [Changelog](https://github.com/yargs/y18n/blob/y18n-v4.0.3/CHANGELOG.md) - [Commits](yargs/y18n@v4.0.0...y18n-v4.0.3) --- updated-dependencies: - dependency-name: y18n dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Brian Clark <clarkio@users.noreply.github.com> * Update README.md * Update README.md * Update README.md * Migrate testing from vscode to @vscode/test-electron (#153) * Migrate testing from vscode to @vscode/test-electron * add: version bump Co-authored-by: clarkio <clarkio@users.noreply.github.com> * docs: add Technickel-Dev as a contributor for code (#163) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> * docs: add Technickel-Dev as a contributor for test (#164) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> * add: version bump details in changelog ignore dccache file * add: github action build and test script * fix: add github action workflow name * add: status badge for new github action * fix: use different port for authentication (#171) * fix: use different port for authentication chore: ignore .dccache file chore: update to latest npm package lock version * version: 1.0.5 * chore: adjust to ignore ts issues for now * fix: remove test folder from webpack use * fix: ci branches used * chore: include latest branch change details --------- Co-authored-by: Anthony Conrad (parithon) <parithon@outlook.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Bit <brandon@microsoft.com> Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> Co-authored-by: Technickel <bradlabrador@hotmail.com>
clarkio
added a commit
that referenced
this pull request
Apr 28, 2023
* Master (#111) * 0.2.2 Release (#103) * HOTFIX: Fixed a registration error with the TreeView containers * bump version and log changes * add launch for runnin with extensions * Major Upgrade (#123) * Redesigned the entire extension (#112) * Refactored enum types into an enums folder. * Generating 'types' so we can provide types for our API we'll be exposing. * API interface has been added * Started initial refactor to App and expose API * App class is now working. * Twitch chat client is now working * Old credentials removed by default * Added an API entry to verify if a user is following the channel * Fixed an error with the twitch login on linux * Twitch Authentication server callback port is now a setting * Fixed inconsistency in command titles * Fixed bearer token issue * Removed 'token' requirement for followers check, not required * Reverted server port back to static 5544. Must match registered app with Twitch * Updated changelog for 0.5.0 * Context menu support (#115) * Remove highlights by context-menu * Updated changelog * Updated node_modules to fix security vulnerabilities (#113) * Remove Types folder (#116) * Ignore types * Removed types folder * Cleanup and fixed some issues (#122) * Fixed a high vulnerability in node * Fixed authentication issues and updated packages * Fixed promise issues in the highlight * Removed declaration generation * Updated webpack plugins and options * Redesigned the entire extension (#112) * Refactored enum types into an enums folder. * Generating 'types' so we can provide types for our API we'll be exposing. * API interface has been added * Started initial refactor to App and expose API * App class is now working. * Twitch chat client is now working * Old credentials removed by default * Added an API entry to verify if a user is following the channel * Fixed an error with the twitch login on linux * Twitch Authentication server callback port is now a setting * Fixed inconsistency in command titles * Fixed bearer token issue * Removed 'token' requirement for followers check, not required * Reverted server port back to static 5544. Must match registered app with Twitch * Updated changelog for 0.5.0 * Context menu support (#115) * Remove highlights by context-menu * Updated changelog * Updated node_modules to fix security vulnerabilities (#113) * Remove Types folder (#116) * Ignore types * Removed types folder * Cleanup and fixed some issues (#122) * Fixed a high vulnerability in node * Fixed authentication issues and updated packages * Fixed promise issues in the highlight * Removed declaration generation * Updated webpack plugins and options * clarify status bar item actions * No longer alert about saving token, log it! * Updated copyfiles to 2.3.0 to hopefully solve linux issue * Fixed some casing issues for references on linux * fix: change casing of 'twitch' Co-authored-by: clarkio <clarkio@users.noreply.github.com> * Bump elliptic from 6.4.1 to 6.5.3 (#124) Bumps [elliptic](https://github.com/indutny/elliptic) from 6.4.1 to 6.5.3. - [Release notes](https://github.com/indutny/elliptic/releases) - [Commits](indutny/elliptic@v6.4.1...v6.5.3) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * 💯 1.0.0 Release🎉🎊✨🎆 * Update README.md * hotfix(correct reading of settings by name) * remove tmi token from readme requirements * update version for patch * fix(only reconnect on config change if previously connected) * sec: fix deps from audit * 1.0.2 Release * fix: adjust whitespace * AddWebTrends-2020-11 (#131) * Added Web Trends * Added Web Trends * Added Web Trends * Added Web Trends * Added Web Trends * Added Web Trends * Create codeql-analysis.yml * fix: move app to use new twitch app client id (#141) * docs: add parithon as a contributor for code (#145) * docs: update README.md [skip ci] * docs: create .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> * docs: add MatthewKosloski as a contributor for code (#146) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> * docs: add yoannfleurydev as a contributor for code (#147) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> * fix build badge * Bump elliptic from 6.5.3 to 6.5.4 (#133) Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.3 to 6.5.4. - [Release notes](https://github.com/indutny/elliptic/releases) - [Commits](indutny/elliptic@v6.5.3...v6.5.4) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Brian Clark <clarkio@users.noreply.github.com> * Bump ssri from 6.0.1 to 6.0.2 (#136) Bumps [ssri](https://github.com/npm/ssri) from 6.0.1 to 6.0.2. - [Release notes](https://github.com/npm/ssri/releases) - [Changelog](https://github.com/npm/ssri/blob/v6.0.2/CHANGELOG.md) - [Commits](npm/ssri@v6.0.1...v6.0.2) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Brian Clark <clarkio@users.noreply.github.com> * Bump path-parse from 1.0.6 to 1.0.7 (#139) Bumps [path-parse](https://github.com/jbgutierrez/path-parse) from 1.0.6 to 1.0.7. - [Release notes](https://github.com/jbgutierrez/path-parse/releases) - [Commits](https://github.com/jbgutierrez/path-parse/commits/v1.0.7) --- updated-dependencies: - dependency-name: path-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Brian Clark <clarkio@users.noreply.github.com> * Bump tar from 6.0.5 to 6.1.11 (#140) Bumps [tar](https://github.com/npm/node-tar) from 6.0.5 to 6.1.11. - [Release notes](https://github.com/npm/node-tar/releases) - [Changelog](https://github.com/npm/node-tar/blob/main/CHANGELOG.md) - [Commits](isaacs/node-tar@v6.0.5...v6.1.11) --- updated-dependencies: - dependency-name: tar dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Brian Clark <clarkio@users.noreply.github.com> * Bump ini from 1.3.5 to 1.3.8 (#142) Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.8. - [Release notes](https://github.com/isaacs/ini/releases) - [Commits](npm/ini@v1.3.5...v1.3.8) --- updated-dependencies: - dependency-name: ini dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Brian Clark <clarkio@users.noreply.github.com> * Bump y18n from 4.0.0 to 4.0.3 (#143) Bumps [y18n](https://github.com/yargs/y18n) from 4.0.0 to 4.0.3. - [Release notes](https://github.com/yargs/y18n/releases) - [Changelog](https://github.com/yargs/y18n/blob/y18n-v4.0.3/CHANGELOG.md) - [Commits](yargs/y18n@v4.0.0...y18n-v4.0.3) --- updated-dependencies: - dependency-name: y18n dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Brian Clark <clarkio@users.noreply.github.com> * Update README.md * Update README.md * Update README.md * Migrate testing from vscode to @vscode/test-electron (#153) * Migrate testing from vscode to @vscode/test-electron * add: version bump Co-authored-by: clarkio <clarkio@users.noreply.github.com> * docs: add Technickel-Dev as a contributor for code (#163) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> * docs: add Technickel-Dev as a contributor for test (#164) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> * add: version bump details in changelog ignore dccache file * add: github action build and test script * fix: add github action workflow name * add: status badge for new github action * fix: use different port for authentication (#171) * fix: use different port for authentication chore: ignore .dccache file chore: update to latest npm package lock version * version: 1.0.5 * chore: adjust to ignore ts issues for now * fix: remove test folder from webpack use * fix: ci branches used * chore: include latest branch change details * Create deploy.yml * add: support for open vsx registry publishing --------- Co-authored-by: Anthony Conrad (parithon) <parithon@outlook.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Bit <brandon@microsoft.com> Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> Co-authored-by: Technickel <bradlabrador@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the recommended way to test vscode extensions has switched from the vscode dependency to @vscode/test-electron, this push makes the changes required to support the new testing setup! This will close #148.
The changes are mainly around file tree structure, new test runner and new test script with the required dependencies.
Side note: package-lock.json did some required version updating which is why there are a larger number of changes than expected
I'm doing this as part of Hacktoberfest and a personal interest in such a cool extension. I do not however have very much experience with vscode extensions so feel free to point out any feedback if you see something!