Using Webpack to reduce our extension size #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parithon
changed the title
|
There appears to be an issue with the source maps that Webpack creates. You set a breakpoint on line 25, but when debugging the breakpoints are in a different location (line 90). Breakpoint before debug: Breakpoint during debug: |
parithon
changed the title
|
Because of the issues with the source maps using Webpack during debugging we will only use Webpack when packaging (pre-publishing) the extension prior to publishing to the marketplace. Webpack will clear out the 'out' folder prior to packaging the javascript. |
parithon
force-pushed
the
use-webpack
branch
from
7a52006
to
601725c
Compare
|
Wow, this is awesome! My only concern is I don't know how to use Webpack but this will finally force me to learn more about it 😄 |
clarkio
reviewed
Feb 18, 2019
clarkio
approved these changes
Feb 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of including node_modules/ with our extension (upwards of 3300 files) in this PR I use webpack to reduce that to 15 files. Not to mention it reduces our size by an awesome 91%!
Without webpack:
With webpack:
Files in VSIX:
