Remove Highlights from Users Banned in Chat #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests are failing because it expects the constants.Commands to be listed among the contribution commands configuration in the package.json file. However, the only commands that should exist in the package.json are those commands that are registered with vscode and executed by the user via the UI. We need to refactor the constants.Commands, as well as the package.json, to separate commands between registered commands (those commands registered with vscode, such as startChat) and internal commands (those commands that aren't registered with vscode, such as removeBannedHighlights). |
parithon
requested changes
Apr 11, 2019
|
I should get to fixing this up tonight. I'll refactor and look to add tests for the internal commands too. |
|
|
CodemanCodes
pushed a commit
to CodemanCodes/vscode-twitch-highlighter
that referenced
this pull request
Aug 27, 2019
…-surlydev docs: add surlydev as a contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finished implementation that was started with mpj on https://twitch.tv/funfunfunction.
Big thanks to @parithon for helping simplify the code for removing highlights based on banned username with function overloads 👍
👉 https://gist.github.com/parithon/7b165c22e797186e7649378aa3a01351
Partially addresses #51