Addressing issue #58 - useWindowAsScrollContainer bug #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix for useWindowAsScrollContainer in firefox
jimyaghi
reviewed
Oct 4, 2017
| @@ -105,12 +105,18 @@ export default function sortableContainer(WrappedComponent, config = {withRef: f | |||
| useWindowAsScrollContainer, | |||
| } = this.props; | |||
|
|
|||
| const findScrollTop = () => { | |||
| if (this.document.body['scrollTop']) { return this.document.body; } | |||
There was a problem hiding this comment.
how about:
if('scrollTop' in this.document.body)
There was a problem hiding this comment.
Also, please note that in Chrome scrollTop is present in both but appears to be writeable ONLY in document.documentElement but not in document.body
|
Closed in favour of #306 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently useWindowAsScrollContainer doesn't work in firefox and internet explorer
document.documentElementordocument.documentBody. I think the code is slightly messy, but probably preferable to inlining an if statement into the existing ternary operator.This works in Firefox - I'm not sure whether this also resolves the issue for internet explorer. I will try and determine and get access to a windows machine and test over the weekend.