Update CGameMenu.cpp #139
Open
Update CGameMenu.cpp #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Changes:** * Fixed a bug where the `CTexture_DrawInRect` call was manually inserted into the code, which could cause stack alignment issues. * * Fixed a bug where the `posX` and `posY` variables were declared without initialization. * Fixed a bug where the code did not check for errors when calling the `MemoryNop` and `MemoryJump` functions. * Added a check that the `CTEXTURE_DRAW_BG_RECT` function call address is valid before inserting a hook. * Stack clearing with `pop ebp` added to `OnDrawMenuBackground` function to properly restore the stack after calling `CTexture_DrawInRect`.
MiranDMC
reviewed
Jun 3, 2024
| } | ||
|
|
||
| void CGameMenu::Inject(CCodeInjector& inj) | ||
| void CGameMenu::Inject(CCodeInjector& inj) |
|
Did you even compiled and ran it? |
x87
force-pushed
the
master
branch
5 times, most recently
from
1e46701
to
50df696
Compare
MiranDMC
requested changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
CTexture_DrawInRectcall was manually inserted into the code, which could cause stack alignment issues.posXandposYvariables were declared without initialization.MemoryNopandMemoryJumpfunctions.CTEXTURE_DRAW_BG_RECTfunction call address is valid before inserting a hook.pop ebpadded toOnDrawMenuBackgroundfunction to properly restore the stack after callingCTexture_DrawInRect.