Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reimplement native methods for reading and storing opcode parameters #165

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from
Draft

Reimplement native methods for reading and storing opcode parameters #165

wants to merge 13 commits into from

Conversation

x87
Copy link

@x87 x87 commented Jul 21, 2024

No description provided.

@x87 x87 changed the title ReImplement arguments read and write methods Reimplement native methods for reading and storing opcode parameters Jul 21, 2024
MiranDMC
MiranDMC reviewed Jul 22, 2024
View reviewed changes
source/CGameVersionManager.cpp
@@ -28,6 +28,7 @@ namespace CLEO
{ 0x00465AA0, memory_und, 0x00465AA0, 0x00465B20, 0x0046B2C0 }, // MA_STOP_SCRIPT_FUNCTION,
{ 0x00465E60, memory_und, 0x00465E60, 0x00465EE0, 0x0046B640 }, // MA_SCRIPT_OPCODE_HANDLER0_FUNCTION,
{ 0x00464080, memory_und, 0x00464080, 0x00464100, 0x00469790 }, // MA_GET_SCRIPT_PARAMS_FUNCTION,
{ 0x00464250, memory_und, memory_und, memory_und, memory_und }, // MA_GET_NEXT_SCRIPT_PARAM_NO_UPDATE_FUNCTION,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it is time to add check for US 1.0 version and throw error message for others.

MiranDMC
MiranDMC reviewed Jul 22, 2024
View reviewed changes
source/CleoBase.cpp
@@ -6,6 +6,7 @@ namespace CLEO
{
CCleoInstance CleoInstance;
CCleoInstance& GetInstance() { return CleoInstance; }
std::stack<int> CleoStack;
Copy link
Collaborator

@MiranDMC MiranDMC Jul 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it should hold SCRIPT_VAR type. Also what with the strings?
Named temp variable stack or something like that.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strings are out of scope for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiranDMC MiranDMC MiranDMC left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@x87 @MiranDMC @DanielSant0s