Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(clerk-js): Render
@clerk/ui
#4114base: main
Are you sure you want to change the base?
feat(clerk-js): Render
@clerk/ui
#4114Changes from 5 commits
9e71651
8f3ea4b
b3ee721
851f201
371f6ee
b8d014f
56af4f5
f0c6f51
2fdd33e
5322329
b9b3359
e3132e3
f000689
9866b16
812035a
da7ba53
3fe0bda
9542bab
a75375f
7f71197
31d749c
4b6c093
86419e0
93c17d2
e264672
4e84b25
4b50d86
02ac475
c245d6f
2aab6cd
8ab9b83
368db81
b40c293
fc3f448
d415f19
477ee05
860897c
2cc9acd
07a26ab
77bd3e0
6bae6c3
3d6d9ae
74c81bf
63f97d3
4746fb4
54a836c
29258d0
c65ea96
bab0ad3
129bc20
98fb7db
62dbb34
dc4149e
163ef01
5035d98
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wanted to point out here that after this refactor we're probably losing the ability to
await
the mount call.This is something not blocking this PR at the moment, but I'd like to verify if that's the case and see if we actually need to ever
await
it or not