Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sv-SE.ts #4292

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Update sv-SE.ts #4292

wants to merge 4 commits into from

Conversation

MarcusT96
Copy link

@MarcusT96 MarcusT96 commented Oct 6, 2024

Description

Edited the swedish localization package to more match the en-US package that is managed by the clerk team. This to make us swedes have a more complete authentication system in swedish and not mix swedish and english as before.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Edited the swedish localization package to more match the en-US package that is managed by the clerk team. This to make us swedes have a more complete authentication system in swedish and not mix swedish and english as before.
Copy link

changeset-bot bot commented Oct 6, 2024

🦋 Changeset detected

Latest commit: 9bdc30f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@clerk/localizations Patch
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@anagstef anagstef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing! 🙏

packages/localizations/src/sv-SE.ts Outdated Show resolved Hide resolved
Copy link
Author

@MarcusT96 MarcusT96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left notes on the ones were I might have gone a bit bananas, sorry!

Copy link
Member

@tmilewski tmilewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarcusT96 Maybe I'm misunderstanding some of your comments, but I think it makes sense to keep some of the original translations I called out here.

Thanks again!

formFieldInputPlaceholder__phoneNumber: 'Ange ditt telefonnummer',
formFieldInputPlaceholder__username: 'Ange ditt användarnamn',
formFieldLabel__automaticInvitations: 'Aktivera automatiska inbjudningar för denna domän',
formFieldLabel__backupCode: undefined,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's revert this, if it makes sense.

Comment on lines +549 to +552
form_param_nil: undefined,
form_param_value_invalid: undefined,
form_password_incorrect: 'Lösenordet är felaktigt.',
form_password_length_too_short: 'Lösenordet är för kort.',
form_password_incorrect: undefined,
form_password_length_too_short: undefined,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's revert these as well, if it makes sense. They seem correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants