-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(localization): Add en-GB #4313
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 2445633 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
4658f7c
to
3fdcdef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ijxy Thank you for this! Please just update the major changeset to minor, and we should be good to go!
c388558
to
2445633
Compare
@@ -164,6 +165,7 @@ run(beBY, 'be-BY'); | |||
run(csCZ, 'cs-CZ'); | |||
run(daDK, 'da-DK'); | |||
run(deDE, 'de-DE'); | |||
run(enGB, 'en-GB'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto-generation will not work as expected if the file has custom logic inside it.
Let's drop the changes of generate.ts
file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's drop the changes of generate.ts
file.
Description
Replaces a couple of "Americanisms" with their British versions:
Checklist
npm test
runs as expected.npm run build
runs as expected.Type of change