Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(express): Export authenticateRequest #4340

Merged
merged 5 commits into from
Oct 16, 2024

Conversation

jescalan
Copy link
Contributor

This can be useful to use directly for express users who want to go down to bare metal

Description

For some users of the express SDK, they may want to directly use authenticateRequest, which is notably different from the backend SDK version since it's adapted to express' request wrapper. This makes that possible.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

This can be useful to use directly for express users who want to go down to bare metal
Copy link

changeset-bot bot commented Oct 15, 2024

🦋 Changeset detected

Latest commit: b3552cc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clerk/express Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@wobsoriano wobsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, let's do this. This one has custom logic that would be a hassle to implement in userland

@LekoArts LekoArts changed the title Express SDK: export authenticateRequest feat(express): Export authenticateRequest Oct 16, 2024
@LekoArts LekoArts enabled auto-merge (squash) October 16, 2024 09:12
@LekoArts LekoArts merged commit 0fdc56c into main Oct 16, 2024
23 checks passed
@LekoArts LekoArts deleted the express-export-authenticate-request branch October 16, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants