middleware.refresh: elide a lock for the "refresh-clear" op
#873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
vemv
commented
May 5, 2024
vemv
commented
bbatsov
reviewed
May 5, 2024
| @@ -76,12 +76,18 @@ | |||
| msg] | |||
| (reload-utils/after-reply error msg)) | |||
|
|
|||
| (def ^{:added "0.48.0"} user-indicated-clear? | |||
There was a problem hiding this comment.
I don't think this name is good, as it's too specific and it's possible that some op might be triggered in a different way as opposed to a direct request from an IDE. (unlikely, but possible) Should this be named just reset-in-progress or something like this?
bbatsov
reviewed
May 5, 2024
| (locking refresh-tracker | ||
| (vreset! refresh-tracker (track/tracker)))) | ||
| ;; This used to be a `locking`-based call to our `clear` implementation | ||
| ;; Now it merely "enqueues" a clearing, because the "refresh-clear" op is called synchronously by CIDER, |
There was a problem hiding this comment.
It's best to avoid CIDER specifics here, as the middleware aims to be client-neutral outside of Emacs-specific features like Eldoc.
|
Thanks! Will re-visit tomorrow. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.