Merge pull request #648 from inno-cloudbarista/azure/sgcreatebugfix

[Azure] SecurityGroup 생성시 rule이 2개일 경우 생성 안되는 현상 수정
cloud-barista · May 16, 2022 · 87ce97b · 87ce97b
2 parents 11dd9e2 + 3fe8bb6
commit 87ce97b
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/cloud-control-manager/cloud-driver/drivers/azure/resources/SecurityHandler.go b/cloud-control-manager/cloud-driver/drivers/azure/resources/SecurityHandler.go
@@ -523,6 +523,7 @@ func addCBDefaultRule(azureSGRuleList *[]network.SecurityRule) (*[]network.Secur
 		FromPort:   fromPort,
 		ToPort:     toPort,
 	}
+	addAllowDefaultRule := false
 	for _, sgRule := range *azureSGRuleList {
 		if sgRule.Access == network.SecurityRuleAccessAllow {
 			protocols := convertRuleProtocolAZToCB(fmt.Sprint(sgRule.Protocol))
@@ -539,11 +540,14 @@ func addCBDefaultRule(azureSGRuleList *[]network.SecurityRule) (*[]network.Secur
 				FromPort:   fromPort,
 				ToPort:     toPort,
 			}
-			if !equalsRule(ruleInfo, cbDefaultAllowSGRuleInfo) {
-				addCBDefaultRuleList = append(addCBDefaultRuleList, cbDefaultAllowSGRule)
+			if equalsRule(ruleInfo, cbDefaultAllowSGRuleInfo) {
+				addAllowDefaultRule = true
 			}
 		}
 	}
+	if !addAllowDefaultRule {
+		addCBDefaultRuleList = append(addCBDefaultRuleList, cbDefaultAllowSGRule)
+	}
 
 	return &addCBDefaultRuleList, nil
 }