Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update KT Cloud Classic NLBHandler DeleteNLB() #1043

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Update KT Cloud Classic NLBHandler DeleteNLB() #1043

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 28 additions & 7 deletions cloud-control-manager/cloud-driver/drivers/ktcloud/resources/NLBHandler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,15 @@ package resources

import (
"fmt"
"strings"
"strconv"
"strings"
"time"
// "github.com/davecgh/go-spew/spew"

call "github.com/cloud-barista/cb-spider/cloud-control-manager/cloud-driver/call-log"
idrv "github.com/cloud-barista/cb-spider/cloud-control-manager/cloud-driver/interfaces"
irs "github.com/cloud-barista/cb-spider/cloud-control-manager/cloud-driver/interfaces/resources"

ktsdk "github.com/cloud-barista/ktcloud-sdk-go"
)

Expand Down Expand Up @@ -197,7 +197,7 @@ func (nlbHandler *KtCloudNLBHandler) DeleteNLB(nlbIID irs.IID) (bool, error) {
return false, newErr
}

// Get KT Cloud NLB VM list
// Get KT Cloud NLB VM list to Remove from the NLB
listResp, err := nlbHandler.NLBClient.ListNLBVMs(nlbIID.SystemId) // Not 'VMClient' or 'NetworkClient' but 'NLBClient'
if err != nil {
newErr := fmt.Errorf("Failed to Get NLB VM list : [%v]", err)
Expand All @@ -207,13 +207,34 @@ func (nlbHandler *KtCloudNLBHandler) DeleteNLB(nlbIID irs.IID) (bool, error) {
time.Sleep(time.Second * 1) // Before 'return'
// To Prevent the Error : "Unable to execute API command listTags due to ratelimit timeout"

cblogger.Info("# Start to Remove the NLB VMs!!")
vmHandler := KtCloudVMHandler{
RegionInfo: nlbHandler.RegionInfo,
Client: nlbHandler.Client,
}
var nlbVMs []irs.IID
if len(listResp.Listnlbvmsresponse.NLBVM) > 0 {
newErr := fmt.Errorf("Failed to Delete the NLB. First Remove the connected VMs of the NLB!!")
cblogger.Error(newErr.Error())
LoggingError(callLogInfo, newErr)
return false, newErr
for _, nlbVM := range listResp.Listnlbvmsresponse.NLBVM {
vmName, err := vmHandler.getVmNameWithId(nlbVM.VMId)
if err != nil {
newErr := fmt.Errorf("Failed to Get the VM Name with the VM ID : [%v]", err)
cblogger.Error(newErr.Error())
return false, newErr
}
nlbVMs = append(nlbVMs, irs.IID{NameId: vmName, SystemId: nlbVM.VMId})
}

_, removeErr := nlbHandler.RemoveVMs(nlbIID, &nlbVMs) // 'NameId' requied!!
if removeErr != nil {
newErr := fmt.Errorf("Failed to Remove the VMs from the New NLB. [%v]", removeErr)
cblogger.Error(newErr.Error())
LoggingError(callLogInfo, newErr)
return false, newErr
}
time.Sleep(time.Second * 3)
}

cblogger.Info("# Start to Delete the NLB!!")
start := call.Start()
delResp, err := nlbHandler.NLBClient.DeleteNLB(nlbIID.SystemId) // Not 'Client'
if err != nil {
Expand Down
Loading