Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug on NS prefix of SG name #1052

Merged

Conversation

jihoon-seo
Copy link
Member

Closes #1051

TB가 SP에 VM 생성을 요청할 때
SG 칸에는 'Spider가 관리하는 SG name' 을 적어야 하는데
이 값은 TB SG object의 cspSecurityGroupName 필드에 있습니다.
이 필드의 값을 활용하도록 수정하는 PR입니다.

AWS는 VM 생성 되는 것을 확인했고,

Alibaba에서는 기존에 발생하던 [aws-ap-southeast-1:aws-ap-southeast-1-jhseo:aws-ap-southeast-1-jhseo] 와 같은 에러는 발생하지 않는 것을 확인했습니다.
(다만, 다른 에러인 The resource in the specified zone is no longer available for sale. Please try other regions and zones. 에러가 발생하여 VM 생성까지는 가지 못했음) (#974 (comment))

@jihoon-seo jihoon-seo added the hold Need to hold merge label Mar 29, 2022
@jihoon-seo jihoon-seo removed the hold Need to hold merge label Mar 29, 2022
@seokho-son
Copy link
Member

일부러 주석처리해둔 상태였군요. 일단 LGTM 입니다!

@seokho-son seokho-son merged commit 869a202 into cloud-barista:main Mar 29, 2022
@jihoon-seo jihoon-seo deleted the 220329_Fix_bug_NS-prefix_SG-name branch March 30, 2022 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot create VM (issue with NS prefix of SG name)
2 participants