Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply veryshort Duration for caching internal GET requests #1544

Merged
merged 1 commit into from
May 3, 2024
Merged

Apply veryshort Duration for caching internal GET requests #1544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/core/common/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ var clientCache = sync.Map{}
var clientRequestCounter = sync.Map{}

const (
// VeryShortDuration is a duration for very short-term cache
VeryShortDuration = 1 * time.Second
// ShortDuration is a duration for short-term cache
ShortDuration = 2 * time.Second
// MediumDuration is a duration for medium-term cache
Expand Down
9 changes: 2 additions & 7 deletions src/core/common/utility.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,7 +434,7 @@ func CheckSpiderReady() error {
SetUseBody(requestBody),
&requestBody,
&callResult,
ShortDuration,
VeryShortDuration,
)

if err != nil {
Expand Down Expand Up @@ -472,8 +472,6 @@ func GetConnConfigList(filterCredentialHolder string, filterVerified bool, filte
return ConnConfigList{}, nil
}

log.Info().Msgf("Filtered connection config count: %d", len(filteredConnections.Connectionconfig))

// filter by credential holder
if filterCredentialHolder != "" {
for _, connConfig := range filteredConnections.Connectionconfig {
Expand All @@ -483,7 +481,6 @@ func GetConnConfigList(filterCredentialHolder string, filterVerified bool, filte
}
filteredConnections = tmpConnections
tmpConnections = ConnConfigList{}
log.Info().Msgf("Filtered connection config count: %d", len(filteredConnections.Connectionconfig))
}

// filter only verified
Expand All @@ -495,7 +492,6 @@ func GetConnConfigList(filterCredentialHolder string, filterVerified bool, filte
}
filteredConnections = tmpConnections
tmpConnections = ConnConfigList{}
log.Info().Msgf("Filtered connection config count: %d", len(filteredConnections.Connectionconfig))
}

// filter only region representative
Expand All @@ -507,9 +503,8 @@ func GetConnConfigList(filterCredentialHolder string, filterVerified bool, filte
}
filteredConnections = tmpConnections
tmpConnections = ConnConfigList{}
log.Info().Msgf("Filtered connection config count: %d", len(filteredConnections.Connectionconfig))
}

log.Info().Msgf("Filtered connection config count: %d", len(filteredConnections.Connectionconfig))
return filteredConnections, nil
}

Expand Down
4 changes: 2 additions & 2 deletions src/core/mcir/common.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ func DelResource(nsId string, resourceType string, resourceId string, forceFlag
common.SetUseBody(requestBody),
&requestBody,
&callResult,
common.ShortDuration,
common.VeryShortDuration,
)

if err != nil {
Expand Down Expand Up @@ -460,7 +460,7 @@ func DelChildResource(nsId string, resourceType string, parentResourceId string,
common.SetUseBody(requestBody),
&requestBody,
&callResult,
common.ShortDuration,
common.VeryShortDuration,
)

if err != nil {
Expand Down
8 changes: 4 additions & 4 deletions src/core/mcis/cluster.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -959,7 +959,7 @@ func RemoveNodeGroup(nsId string, clusterId string, nodeGroupName string, forceF
common.SetUseBody(requestBody),
&requestBody,
&ifRes,
common.ShortDuration,
common.VeryShortDuration,
)

if err != nil {
Expand Down Expand Up @@ -1049,7 +1049,7 @@ func SetAutoscaling(nsId string, clusterId string, nodeGroupName string, u *TbSe
common.SetUseBody(requestBody),
&requestBody,
&ifRes,
common.ShortDuration,
common.VeryShortDuration,
)

if err != nil {
Expand Down Expand Up @@ -1134,7 +1134,7 @@ func ChangeAutoscaleSize(nsId string, clusterId string, nodeGroupName string, u
common.SetUseBody(requestBody),
&requestBody,
&spChangeAutoscaleSizeRes,
common.ShortDuration,
common.VeryShortDuration,
)

if err != nil {
Expand Down Expand Up @@ -1488,7 +1488,7 @@ func DeleteCluster(nsId string, clusterId string, forceFlag string) (bool, error
common.SetUseBody(requestBody),
&requestBody,
&ifRes,
common.ShortDuration,
common.VeryShortDuration,
)

if forceFlag == "true" {
Expand Down