[k8scluster] update CheckNodeGroupsOnK8sCreation API #1715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sykim-etri
commented
Aug 14, 2024
sykim-etri
commented
- route to RestCheckNodeGroupsOnK8sCreation
- return K8sClusterNodeGroupsOnCreation(json)
- add testscript for CheckNodeGroupsOnK8sCreation
- route to RestCheckNodeGroupsOnK8sCreation - return K8sClusterNodeGroupsOnCreation(json) - add testscript for CheckNodeGroupsOnK8sCreation
|
@sykim-etri 추가적으로, 정상 동작하지 않는 API는 설명 부분에 대략.. (WIP: This feature may not be fully functional yet) 라는 표기를 해주시면 감사하겠습니다. (swagger에 표기되도록) |
테스트가 완료되어서 정상 동작하는 API입니다. |
|
/approve |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.