Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code scanning alert no. 507: Use of insecure HostKeyCallback implementation #1853

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

seokho-son
Copy link
Member

Fixes https://github.com/cloud-barista/cb-tumblebug/security/code-scanning/507

To fix the problem, we need to replace the insecure HostKeyCallback implementation with a secure one. The best way to do this is to use the ssh.FixedHostKey function, which validates the host key against a predefined allow list. This involves reading the allowed host key from a file and using it to create the ssh.ClientConfig.

  1. Read the allowed host key from a file.
  2. Parse the host key using ssh.ParsePublicKey.
  3. Use the parsed key with ssh.FixedHostKey to set the HostKeyCallback field in ssh.ClientConfig.

Suggested fixes powered by Copilot Autofix. Review carefully before merging.

…ementation

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant