Fix code scanning alert no. 507: Use of insecure HostKeyCallback implementation #1853
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/cloud-barista/cb-tumblebug/security/code-scanning/507
To fix the problem, we need to replace the insecure
HostKeyCallback
implementation with a secure one. The best way to do this is to use thessh.FixedHostKey
function, which validates the host key against a predefined allow list. This involves reading the allowed host key from a file and using it to create thessh.ClientConfig
.ssh.ParsePublicKey
.ssh.FixedHostKey
to set theHostKeyCallback
field inssh.ClientConfig
.Suggested fixes powered by Copilot Autofix. Review carefully before merging.