Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor interruption #79

Merged
merged 2 commits into from
Sep 29, 2023
Merged

Refactor interruption #79

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
701d0fe
Refactor interruption
mbilski Sep 29, 2023
2f7a558
Merge branch 'master' into feature/int
mbilski Sep 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge branch 'master' into feature/int
  • Loading branch information
@mbilski
mbilski committed Sep 29, 2023
commit 2f7a558010103b66bee03c4496248a060ab82777
4 changes: 4 additions & 0 deletions internal/oauth2/oauth2.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,11 @@ func WaitForCallback(clientConfig ClientConfig, serverConfig ServerConfig, hc *h
}
}()

timeout := time.After(clientConfig.BrowserTimeout)

select {
case <-timeout:
return request, errors.New("timeout")
case <-done:
return request, err
}
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.