Add support for RSockets with Spring #349
Conversation
Also generically can support structured events with any Spring API that works with Encoder and Decoder. There's a sample for the RSocket case with a simple request-response echo server. Signed-off-by: Dave Syer <dsyer@vmware.com>
There was a problem hiding this comment.
Can you add some doc about these 2 new encoder/decoder here? https://github.com/cloudevents/sdk-java/blob/master/docs/spring.md
Can you also check all the copyrights and have them like this one? https://github.com/cloudevents/sdk-java/blob/master/core/src/main/java/io/cloudevents/core/CloudEventUtils.java#L1
spring/src/main/java/io/cloudevents/spring/codec/CloudEventDecoder.java
Outdated
Show resolved
Hide resolved
spring/src/main/java/io/cloudevents/spring/codec/CloudEventEncoder.java
Outdated
Show resolved
Hide resolved
examples/spring-rsocket/src/test/java/io/cloudevents/examples/spring/DemoApplicationTests.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Dave Syer <dsyer@vmware.com>
|
I changed the copyrights to match the example (but also noticed that the other Spring module source code do not precisely match BTW). I also added a link and a mention to the docs - there isn't much detail there for any of the converters, but I'd be more than happy to add some notes independently of this PR. |
It would be nice if you can do another PR to fix them 😄
Sure, these docs are really drafted and i'll be more than happy to see them growing! |
Also generically can support structured events with any Spring
API that works with Encoder and Decoder. There's a sample for
the RSocket case with a simple request-response echo server.