Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix time argument parsing for gencrl #683

Merged
merged 1 commit into from
Jan 31, 2017
Merged

Conversation

Xeroday
Copy link
Contributor

@Xeroday Xeroday commented Oct 20, 2016

Usage of gencrl:
cfssl gencrl INPUTFILE CERT KEY TIME

Arguments:
...
TIME (OPTIONAL): The desired expiration from now, in seconds

This PR uses the time argument as a string (as expected from the usage). The current code takes the time arg and uses it as a file name to read from.

Eg:
PR: ./cfssl gencrl serials.txt cert.pem key.pem 86400
Current: ./cfssl gencrl serials.txt cert.pem key.pem time.txt where time.txt has contents '86400'.

@codecov-io
Copy link

codecov-io commented Oct 20, 2016

Current coverage is 58.29% (diff: 100%)

Merging #683 into master will increase coverage by 0.08%

@@             master       #683   diff @@
==========================================
  Files            74         74          
  Lines          6436       6433     -3   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           3746       3750     +4   
+ Misses         2330       2323     -7   
  Partials        360        360          

Powered by Codecov. Last update 0fc38e1...8f85b6b

@lziest lziest self-requested a review January 31, 2017 22:11
@lziest lziest merged commit 41f74f8 into cloudflare:master Jan 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants