Fix nil pointer panic in ParseCSRPEM #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lziest
reviewed
Mar 7, 2017
helpers/helpers.go
Outdated
| block, _ := pem.Decode([]byte(csrPEM)) | ||
| der := block.Bytes |
There was a problem hiding this comment.
more elegant way is that check block and throw error immediately, instead of relying on CSR parsing to catch the empty input.
…be parsed as a PEM block. Signed-off-by: cyli <cyli@twistedmatrix.com>
lziest
approved these changes
Mar 7, 2017
|
won't wait for the snail-speed OSX CI env |
|
Thanks! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
ParseCSRPEMwill panic if the CSR bytes to be parsed cannot be decoded as a valid PEM block. This adds a check to ensure that the block is valid before passing the DER bytes tox509.ParseCertificateRequest.