temp-fix: rendering error in next.js 14.0.2 caused by next.js bug #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b1ed49c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
james-elicx
changed the title
|
🧪 Prereleases are available for testing 🧪 @cloudflare/next-on-pagesYou can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/next-on-pages/runs/6834724449/npm-package-next-on-pages-534@cloudflare/eslint-plugin-next-on-pagesYou can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/next-on-pages/runs/6834724449/npm-package-eslint-plugin-next-on-pages-534 |
packages/next-on-pages/src/buildApplication/processVercelFunctions/dedupeEdgeFunctions.ts
Outdated
Show resolved
Hide resolved
dario-piotrowicz
approved these changes
Nov 11, 2023
…ions/dedupeEdgeFunctions.ts
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vercel/next.js#57815 introduced a critical bug for us that breaks rendering due to the assumption that their internal request shape is always
NodeNextRequest(and should have theoriginalRequestproperty on it), and is neverWebNextRequest(which doesn't have theoriginalRequestproperty).This fix is intended to be a temporary band-aid until the issue is fixed in Next.js. I raised an issue at vercel/next.js#58265.