Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 BUG: D1 migration apply output is sketchy #2734

Closed
rozenmd opened this issue Feb 15, 2023 · 1 comment
Closed

🐛 BUG: D1 migration apply output is sketchy #2734

rozenmd opened this issue Feb 15, 2023 · 1 comment
Assignees
Labels
bug Something that isn't working d1 Relating to D1

Comments

@rozenmd
Copy link
Contributor

rozenmd commented Feb 15, 2023

Which Cloudflare product(s) does this pertain to?

D1

What version of Wrangler are you using?

latest

What operating system are you using?

Mac

Describe the Bug

Ignoring the sheer verbosity, we shouldn't be logging in executeSql for system queries that determine migration state.

rozenmd@cf-laptop d1-test-999 % npx wrangler d1 migrations apply db --preview
▲ [WARNING] Processing wrangler.toml configuration:

    - D1 Bindings are currently in alpha to allow the API to evolve before general availability.
      Please report any issues to https://github.com/cloudflare/workers-sdk/issues/new/choose
      Note: Run this command with the environment variable NO_D1_WARNING=true to hide this message
  
      For example: `export NO_D1_WARNING=true && wrangler <YOUR COMMAND HERE>`


--------------------
🚧 D1 is currently in open alpha and is not recommended for production data and traffic
🚧 Please report any bugs to https://github.com/cloudflare/workers-sdk/issues/new/choose
🚧 To request features, visit https://community.cloudflare.com/c/developers/d1
🚧 To give feedback, visit https://discord.gg/cloudflaredev
--------------------

🌀 Mapping SQL input into an array of statements
🌀 Parsing 1 statements
🌀 Executing on db (f756d319-b374-4eeb-8df1-d21f10e74138):
🚣 Executed 2 commands in 147.76847300000009ms
🌀 Mapping SQL input into an array of statements
🌀 Parsing 1 statements
🌀 Executing on db (f756d319-b374-4eeb-8df1-d21f10e74138):
🚣 Executed 1 command in 1.4093039999997927ms
Migrations to be applied:
┌───────────────┐
│ Name          │
├───────────────┤
│ 0000_test.sql │
└───────────────┘
? About to apply 1 migration(s)
Your database may not be available to serve requests during the migration, continue? › (Y/n)
@rozenmd rozenmd added bug Something that isn't working d1 Relating to D1 labels Feb 15, 2023
@rozenmd rozenmd self-assigned this Feb 15, 2023
@rozenmd
Copy link
Contributor Author

rozenmd commented May 30, 2023

Closed by #3124 - fix should be available in wrangler@beta in a few minutes.

@rozenmd rozenmd closed this as completed May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that isn't working d1 Relating to D1
Projects
None yet
Development

No branches or pull requests

1 participant