-
Notifications
You must be signed in to change notification settings - Fork 688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wrangler]: fix missing error on failed d1 migrations #3124
[wrangler]: fix missing error on failed d1 migrations #3124
Conversation
🦋 Changeset detectedLatest commit: 69e4f85 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dffad5c
to
5a19379
Compare
I'm not actually a maintainer, just someone pretty familiar with the repo 😅 |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5119831012/npm-package-wrangler-3124 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/3124/npm-package-wrangler-3124 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5119831012/npm-package-wrangler-3124 dev path/to/script.js Additional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5119831012/npm-package-cloudflare-pages-shared-3124 Note that these links will no longer work once the GitHub Actions artifact expires. |
Codecov Report
@@ Coverage Diff @@
## main #3124 +/- ##
==========================================
+ Coverage 74.83% 75.42% +0.58%
==========================================
Files 179 182 +3
Lines 10813 11063 +250
Branches 2853 2902 +49
==========================================
+ Hits 8092 8344 +252
+ Misses 2721 2719 -2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do set the exit code directly in other parts of Wrangler but that is probably not ideal.
LGTM. |
Fixes #2358.
What this PR solves / how to test:
Returns error code from failed d1 migrations.
Associated docs issue(s)/PR(s):
Author has included the following, where applicable:
Reviewer has performed the following, where applicable: