Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turbo tweaks #3450

Merged
merged 3 commits into from
Jun 13, 2023
Merged

Turbo tweaks #3450

merged 3 commits into from
Jun 13, 2023

Conversation

petebacondarwin
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Jun 13, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: ed13aa4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jun 13, 2023 •
edited
Loading

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5259403659/npm-package-wrangler-3450

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/3450/npm-package-wrangler-3450

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5259403659/npm-package-wrangler-3450 dev path/to/script.js
Additional artifacts: 
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5259403659/npm-package-cloudflare-pages-shared-3450

Note that these links will no longer work once the GitHub Actions artifact expires.

@codecov
Copy link

codecov bot commented Jun 13, 2023 •
edited
Loading

Codecov Report

Merging #3450 (ed13aa4) into main (be15640) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3450      +/-   ##
==========================================
+ Coverage   75.17%   75.21%   +0.04%     
==========================================
  Files         183      183              
  Lines       11052    11052              
  Branches     2904     2904              
==========================================
+ Hits         8308     8313       +5     
+ Misses       2744     2739       -5

see 3 files with indirect coverage changes

rozenmd
rozenmd approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@rozenmd rozenmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

GregBrimble
GregBrimble approved these changes Jun 13, 2023
View reviewed changes
Copy link
Member

@GregBrimble GregBrimble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of questions

@petebacondarwin petebacondarwin requested review from a team as code owners June 13, 2023 14:01
JacobMGEvans
JacobMGEvans approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@JacobMGEvans JacobMGEvans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!

@petebacondarwin
Move vitest timeouts to the top level
772f67c
@petebacondarwin
Fix up remix dependencies in wrangler fixture
8b1b028 
There was a version mismatch between different parts of the Remix libraries, which caused a server error.
@petebacondarwin
Increase vitest teardown timeout and use atomics
ed13aa4
@petebacondarwin petebacondarwin merged commit 8d38577 into cloudflare:main Jun 13, 2023
@petebacondarwin petebacondarwin deleted the turbo-tweaks branch June 13, 2023 19:16
lrapoport-cf pushed a commit that referenced this pull request Aug 11, 2023
@petebacondarwin @lrapoport-cf
Turbo tweaks (#3450)
550800b 
* Move vitest timeouts to the top level

* Fix up remix dependencies in wrangler fixture

There was a version mismatch between different parts of the Remix libraries, which caused a server error.

* Increase vitest teardown timeout and use atomics
This was referenced Sep 1, 2023
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Sep 2, 2023
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rozenmd rozenmd rozenmd approved these changes

@GregBrimble GregBrimble GregBrimble approved these changes

@JacobMGEvans JacobMGEvans JacobMGEvans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@petebacondarwin @rozenmd @GregBrimble @JacobMGEvans