Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CODEOWNERS #3451

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Update CODEOWNERS #3451

merged 1 commit into from
Jun 13, 2023

Conversation

rozenmd
Copy link
Contributor

@rozenmd rozenmd commented Jun 13, 2023

I just noticed the prior PR means ONLY the codeowners can approve in particular folders - we just want to be notified when folks modify d1 files, not necessarily be a blocker.

@rozenmd rozenmd requested a review from a team as a code owner June 13, 2023 14:17
@changeset-bot
Copy link

changeset-bot bot commented Jun 13, 2023

⚠️ No Changeset found

Latest commit: ea57cc5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@rozenmd rozenmd requested a review from a team June 13, 2023 14:17
@github-actions
Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5256632903/npm-package-wrangler-3451

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/3451/npm-package-wrangler-3451

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5256632903/npm-package-wrangler-3451 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5256632903/npm-package-cloudflare-pages-shared-3451

Note that these links will no longer work once the GitHub Actions artifact expires.

@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #3451 (ea57cc5) into main (8414964) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3451      +/-   ##
==========================================
+ Coverage   75.17%   75.21%   +0.04%     
==========================================
  Files         183      183              
  Lines       11052    11052              
  Branches     2904     2904              
==========================================
+ Hits         8308     8313       +5     
+ Misses       2744     2739       -5     

see 3 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants